[App Service] az functionapp create: Create consumption plan when creating the function app
#30612
Conversation
kamperiadis
requested review from
jsntcy,
zhoxing-ms and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @kamperiadis, |
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
|
|
@zhoxing-ms It seems the test failures are just happening because the name does not match
Is there any way for this name validation to be ignored? Or do I just need to convert these tests to be run live instead? |
kamperiadis
force-pushed
the
consumpplancreation
branch
from
305c42c to
f93258b
Compare
kamperiadis
force-pushed
the
consumpplancreation
branch
from
f93258b to
900d762
Compare
|
The tests in this PR fail for the same reason this other PR fails: #30605 (comment) Should we make these tests run in live mode instead? |
| @@ -4922,6 +4922,11 @@ def create_functionapp(cmd, resource_group_name, name, storage_account, plan=Non | |||
| functionapp_def.kind = 'functionapp' | |||
| # if os_type is None, the os type is windows | |||
| is_linux = bool(os_type and os_type.lower() == LINUX_OS_NAME) | |||
| plan_name = generatePlanName(resource_group_name) | |||
There was a problem hiding this comment.
I think this is the reason why the recording tests failed. A new random plan name will be generated when each time this function is run. Thus, when tests are run under recording mode, the plan name is generated again and different from what in the recoding file.
azure-cli/src/azure-cli/azure/cli/command_modules/appservice/custom.py
Lines 5394 to 5398 in 900d762
There was a problem hiding this comment.
Hi @yanzhudd We actually do intend to create a new plan resource with a new name on behalf of the customer. Does this mean we should just make the tests run live? Or what would you require for this PR to be merged?
There was a problem hiding this comment.
yes, please mark the related tests as live only, and remove the corresponding recording files as well.
There was a problem hiding this comment.
Done! Thank you @yanzhudd. The PR is ready to be merged. Can you please review/merge it?
yanzhudd
changed the title
az functionapp create: Create consumption plan when creating the function appaz functionapp create: Create consumption plan when creating the function app
kamperiadis
force-pushed
the
consumpplancreation
branch
from
ca01570 to
6b0a7d9
Compare
Related command
az functionapp createDescription
Resolves #28944
This issue is happening because we are currently relying on the backend to create the consumption plan but instead, the Az CLI should be creating the plan and then passing that in the payload to the backend.
Testing Guide
az functionapp create -c <location> -n <name> -g <resourceGroupName> --runtime <runtime> -s <storageName> --functions-version 4History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.